Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove bad symlink used for tests #10527

Merged
merged 2 commits into from Sep 6, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Sep 5, 2022

Removes a symlink which points outside the repositry and breaks some build systems.

Instead, create the symlink on the fly.

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #10527 (26a79bc) into master (a60dd36) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 26a79bc differs from pull request most recent head dc18d73. Consider uploading reports for the commit dc18d73 to get more accurate results

@@            Coverage Diff             @@
##           master   #10527      +/-   ##
==========================================
- Coverage   45.76%   45.73%   -0.04%     
==========================================
  Files         234      234              
  Lines       28460    28460              
==========================================
- Hits        13025    13015      -10     
- Misses      13658    13668      +10     
  Partials     1777     1777              
Impacted Files Coverage Δ
reposerver/repository/repository.go 61.04% <0.00%> (-0.92%) ⬇️
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: jannfis <jann@mistrust.net>
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis enabled auto-merge (squash) September 6, 2022 19:35
@jannfis jannfis merged commit 9de5a14 into argoproj:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants