docs: fix link in auth0.md #10531
Merged
docs: fix link in auth0.md #10531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to the user management overview page is not working, so I replaced it and slightly changed the line. If you want any more changes please tell me. Signed-off-by: Kalyan Vurugonda <Vurugondakalyan811@gmail.com>
kalyan-vurugonda
changed the title
Codecov ReportBase: 45.76% // Head: 45.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10531 +/- ##
==========================================
- Coverage 45.76% 45.67% -0.09%
==========================================
Files 236 236
Lines 28529 28699 +170
==========================================
+ Hits 13055 13108 +53
- Misses 13669 13799 +130
+ Partials 1805 1792 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi @terrytangyuan @rbreeze, can you please look into the PR when you have time. |
rbreeze
approved these changes
Sep 8, 2022
crenshaw-dev
requested changes
Sep 9, 2022
crenshaw-dev
added
the
cherry-pick/2.4
I reverted the line as you mentioned change Signed-off-by: Kalyan Vurugonda <Vurugondakalyan811@gmail.com>
I have removed the new line at the end. Signed-off-by: Kalyan Vurugonda <Vurugondakalyan811@gmail.com>
This should make both GitHub and RTD links work. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
changed the title
crenshaw-dev
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
link works in both GitHub and RTD. Thanks @kalyan-vurugonda!
crenshaw-dev
removed
the
cherry-pick/2.4
crenshaw-dev
approved these changes
Oct 9, 2022
There was a problem hiding this comment.
lgtm, thanks @kalyan-vurugonda!
Not going to cherry-pick, because I think the issue is only in GitHub, not in RTC.
|
Thank you @crenshaw-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the user management overview page is not working, so I replaced it and slightly changed the line.
If you want any more changes please tell me.
Signed-off-by: Kalyan Vurugonda Vurugondakalyan811@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: