fix: show revision in badge when param is true

[thijsvtol]

Signed-off-by: Thijs van Tol 43065692+thijsvtol@users.noreply.github.com

Description:
If I use the api for retrieving the badges, the revision will always be shown when the revision query param is present.
So for example if you call https://sample.com/api/badge?name=tomato-service?revision=false it will return the badge WITH the revision.

So this PR fixes that it will only show the revision if the value is true

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 45.75% // Head: 45.75% // No change to project coverage 👍

Coverage data is based on head (6ba6941) compared to base (c05b1c2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10545   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         236      236           
  Lines       28527    28527           
=======================================
  Hits        13053    13053           
  Misses      13669    13669           
  Partials     1805     1805           

Impacted Files	Coverage Δ
server/badge/badge.go	84.28% <100.00%> (ø)
util/settings/settings.go	51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[thijsvtol]

@crenshaw-dev please review and merge

[crenshaw-dev]

lgtm, thanks @thijsvtol!

Out of an abundance of caution, I'm only going to cherry-pick this into 2.5. If folks desperately need this in prior versions, I'll consult with #argo-contributors in Slack before cherry-picking.

[crenshaw-dev]

Cherry-picked onto release-2.5 for 2.5.0-rc2.