Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: appset PR generator docs fixes #10567

Merged
merged 3 commits into from Oct 12, 2022
Merged

docs: appset PR generator docs fixes #10567

merged 3 commits into from Oct 12, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

No description provided.

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Sep 11, 2022
@crenshaw-dev
docs: appset PR generator docs fixes
68b7a1e 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
oh, that field is actually a thing
ef61fe1 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited

Codecov Report

Base: 45.70% // Head: 45.68% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7a4fd12) compared to base (a1279e0).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10567      +/-   ##
==========================================
- Coverage   45.70%   45.68%   -0.02%     
==========================================
  Files         236      236              
  Lines       28668    28668              
==========================================
- Hits        13102    13098       -4     
- Misses      13772    13775       +3     
- Partials     1794     1795       +1
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ashutosh16
ashutosh16 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabusaa
Copy link
Contributor

mabusaa commented Oct 1, 2022

i think this already fixed by this #10642

@crenshaw-dev
Merge branch 'master' into appset-docs-fixes
7a4fd12 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

@mabusaa resolved conflicts and left a few small changes. :-)

terrytangyuan
terrytangyuan reviewed Oct 2, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider lower case the file names for appsets, e.g. Generators-Pull-Request.md -> generators-pull-request.md

@crenshaw-dev
Copy link
Collaborator Author

@terrytangyuan fair. I think I'll save that for another cleanup PR. There are a lot of naming inconsistencies in the docs right now.

@mubarak-j
Copy link
Contributor

I think it's worth adding an explanation for requeueAfterSeconds and when can it be used in the template spec page.

@leoluz leoluz merged commit dc69539 into argoproj:master Oct 12, 2022
@crenshaw-dev crenshaw-dev deleted the appset-docs-fixes branch October 12, 2022 15:10
crenshaw-dev added a commit that referenced this pull request Oct 12, 2022
@crenshaw-dev
docs: appset PR generator docs fixes (#10567)
b735c00 
* docs: appset PR generator docs fixes

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* oh, that field is actually a thing

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Oct 12, 2022
@crenshaw-dev
docs: appset PR generator docs fixes (#10567)
187cd43 
* docs: appset PR generator docs fixes

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* oh, that field is actually a thing

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto release-2.4 for 2.4.15 and release-2.5 for 2.5.0-rc3.

@crenshaw-dev crenshaw-dev mentioned this pull request Jan 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@ashutosh16 ashutosh16 ashutosh16 approved these changes

@jgwest jgwest Awaiting requested review from jgwest

Assignees
No one assigned
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crenshaw-dev @mabusaa @mubarak-j @leoluz @terrytangyuan @ashutosh16