Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hetki to organizations #10586

Merged
merged 2 commits into from Sep 30, 2022
Merged

Added Hetki to organizations #10586

merged 2 commits into from Sep 30, 2022

Conversation

tdi
Copy link
Contributor

@tdi tdi commented Sep 14, 2022

Added Hetki.ai where ArgoCD is the main CD for k8s clusters.

Signed-off-by: Darek Dwornikowski dariusz.dwornikowski@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • [ x] Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Added Hetki.ai where ArgoCD is the main CD for k8s clusters.

Signed-off-by: Darek Dwornikowski <dariusz.dwornikowski@gmail.com>
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 45.69% // Head: 45.75% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (27a9f97) compared to base (9fac0f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10586      +/-   ##
==========================================
+ Coverage   45.69%   45.75%   +0.06%     
==========================================
  Files         234      236       +2     
  Lines       28508    28527      +19     
==========================================
+ Hits        13027    13053      +26     
+ Misses      13694    13669      -25     
- Partials     1787     1805      +18     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/repository_types.go 58.06% <0.00%> (-10.55%) ⬇️
util/argo/audit_logger.go 88.00% <0.00%> (-7.66%) ⬇️
server/application/logs.go 81.25% <0.00%> (-4.47%) ⬇️
util/argo/argo.go 64.43% <0.00%> (-1.54%) ⬇️
cmd/argocd/commands/login.go 2.17% <0.00%> (-0.08%) ⬇️
cmd/argocd/commands/root.go 1.96% <0.00%> (-0.04%) ⬇️
server/account/account.go 69.62% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
server/rbacpolicy/rbacpolicy.go 82.35% <0.00%> (ø)
applicationset/generators/merge.go 59.04% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdi thanks for the PR! Can you readjust the numbering to be all 1s?

@tdi
Copy link
Contributor Author

tdi commented Sep 16, 2022

@tdi thanks for the PR! Can you readjust the numbering to be all 1s?

Hey sure. Should I move all others to 1s too ?

@crenshaw-dev
Copy link
Collaborator

Yes please! They should all start with 1..

Substitute all the lines number with 1.

Signed-off-by: Darek Dwornikowski <dariusz.dwornikowski@gmail.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdi!

@crenshaw-dev crenshaw-dev merged commit fe61938 into argoproj:master Sep 30, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* Add Hetki to organizations

Added Hetki.ai where ArgoCD is the main CD for k8s clusters.

Signed-off-by: Darek Dwornikowski <dariusz.dwornikowski@gmail.com>

* Update USERS.md

Substitute all the lines number with 1.

Signed-off-by: Darek Dwornikowski <dariusz.dwornikowski@gmail.com>

Signed-off-by: Darek Dwornikowski <dariusz.dwornikowski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants