Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: syncWindows in project.yaml #10591

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

Just noticed that this was missing from the example doc.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Sep 14, 2022
@crenshaw-dev crenshaw-dev changed the title Sync windows project docs docs: syncWindows in project.yaml Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 45.69% // Head: 45.76% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (0aaef68) compared to base (ed9cddb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10591      +/-   ##
==========================================
+ Coverage   45.69%   45.76%   +0.07%     
==========================================
  Files         234      236       +2     
  Lines       28508    28519      +11     
==========================================
+ Hits        13027    13053      +26     
+ Misses      13694    13661      -33     
- Partials     1787     1805      +18     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/repository_types.go 58.06% <0.00%> (-10.55%) ⬇️
util/argo/audit_logger.go 88.00% <0.00%> (-7.66%) ⬇️
server/application/logs.go 81.25% <0.00%> (-4.47%) ⬇️
util/argo/argo.go 64.43% <0.00%> (-1.54%) ⬇️
cmd/argocd/commands/root.go 1.96% <0.00%> (-0.04%) ⬇️
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
server/rbacpolicy/rbacpolicy.go 82.35% <0.00%> (ø)
applicationset/generators/merge.go 59.04% <0.00%> (ø)
applicationset/generators/matrix.go 70.73% <0.00%> (ø)
pkg/apis/application/v1alpha1/register.go 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 11c44f2 into argoproj:master Oct 1, 2022
@crenshaw-dev crenshaw-dev deleted the sync-windows-project-docs branch October 1, 2022 23:59
crenshaw-dev added a commit that referenced this pull request Oct 1, 2022
* docs: syncWindows in project.yaml

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* trailing newline

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto release-2.4 for 2.4.13.

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* docs: syncWindows in project.yaml

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* trailing newline

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants