added ./ for broken url link #10623
Merged
added ./ for broken url link #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.75% // Head: 45.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10623 +/- ##
=======================================
Coverage 45.75% 45.75%
=======================================
Files 236 236
Lines 28527 28527
=======================================
Hits 13053 13053
Misses 13669 13669
Partials 1805 1805
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
RutviShukla
force-pushed
the
master
branch
2 times, most recently
from
5d1701f
to
9e9d08d
Compare
leoluz
requested changes
Sep 16, 2022
docs/getting_started.md
Outdated
Comment on lines
147
to
151
| Command for setting default namespace: | ||
|
|
||
| ```bash | ||
| kubectl config set-context --current --namespace=argocd | ||
| ``` |
There was a problem hiding this comment.
Please move this section after line 139.
I would also suggest to change the text "Command for setting default namespace" to "First we need to set the current namespace to argocd running the following command:"
Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu>
Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu>
Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu>
Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu>
leoluz
approved these changes
Sep 17, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* added ./ for broken url link Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu> * added command for setting default namespace Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu> * added command for setting default namespace Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu> * relocated incommand related to setting default namespace Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu> Signed-off-by: RutviShukla <rutvi.shukla@ufl.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the broken URL link that was giving the 404 error by adding ./at the beginning of the URL link.
fixes #10376