tests: cmd unit test version #10689
Merged
tests: cmd unit test version #10689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Codecov ReportBase: 45.76% // Head: 45.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10689 +/- ##
==========================================
+ Coverage 45.76% 45.87% +0.11%
==========================================
Files 236 236
Lines 28529 28530 +1
==========================================
+ Hits 13055 13087 +32
+ Misses 13669 13637 -32
- Partials 1805 1806 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: emirot <emirot.nolan@gmail.com>
jannfis
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Thanks a lot @emirot!
Didn't know that cobra provides some of those methods that can be leveraged to actually write some proper unit tests for commands. TIL :)
I have one minor request for change regarding the unit test, please see below.
Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
…o-cd into cmd/unit_test_version
jannfis
approved these changes
Sep 27, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* tests: add unit test version command Signed-off-by: emirot <emirot.nolan@gmail.com> * tests: add unit test version command Signed-off-by: emirot <emirot.nolan@gmail.com> * tests: add unit test version command Signed-off-by: emirot <emirot.nolan@gmail.com> * tests: add unit test version command Signed-off-by: emirot <emirot.nolan@gmail.com> * tests: add unit test version command Signed-off-by: emirot <emirot.nolan@gmail.com> * tests: client version Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit test on client version and small refactoring.
As there is no previous tests, some manual testing to make sure it didn't break anything: