Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide better error message when application source is missing some settings #10694

Merged
merged 1 commit into from Sep 26, 2022

Conversation

cleverhu
Copy link
Contributor

Closes: #10684
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 45.75% // Head: 45.75% // No change to project coverage 👍

Coverage data is based on head (ca3e776) compared to base (02bf903).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10694   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         236      236           
  Lines       28527    28527           
=======================================
  Hits        13053    13053           
  Misses      13669    13669           
  Partials     1805     1805           
Impacted Files Coverage Δ
util/argo/argo.go 64.43% <100.00%> (ø)
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @cleverhu !

@jannfis jannfis changed the title optimize validate message fix: Provide better error message when application source is missing some settings Sep 26, 2022
@jannfis jannfis merged commit 34392a5 into argoproj:master Sep 26, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
…some settings (argoproj#10694)

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

...repoURL and ...path either ...chart are required message isn't grammatical
2 participants