Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for server version #10720

Merged
merged 8 commits into from Oct 19, 2022

Conversation

emirot
Copy link
Contributor

@emirot emirot commented Sep 27, 2022

Signed-off-by: emirot emirot.nolan@gmail.com

Adding test for cli on server version.

Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 45.62% // Head: 45.63% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ffe8271) compared to base (16613fe).
Patch coverage: 19.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10720      +/-   ##
==========================================
+ Coverage   45.62%   45.63%   +0.01%     
==========================================
  Files         236      236              
  Lines       28699    28708       +9     
==========================================
+ Hits        13093    13100       +7     
- Misses      13805    13806       +1     
- Partials     1801     1802       +1     
Impacted Files Coverage Δ
cmd/argocd/commands/root.go 5.88% <0.00%> (ø)
cmd/argocd/commands/version.go 38.14% <20.00%> (+4.05%) ⬆️
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @emirot!

@crenshaw-dev crenshaw-dev merged commit d207de2 into argoproj:master Oct 19, 2022
nsinghal12 pushed a commit to nsinghal12/argo-cd that referenced this pull request Oct 20, 2022
* test: add unit test for server version

Signed-off-by: emirot <emirot.nolan@gmail.com>

* test: add unit test for server version

Signed-off-by: emirot <emirot.nolan@gmail.com>

* test: add unit test for server version

Signed-off-by: emirot <emirot.nolan@gmail.com>

* tests: update cmd dependencies

Signed-off-by: emirot <emirot.nolan@gmail.com>

Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Niti Singhal <gupta.sweet.niti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants