Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health checks for iam.cnrm.cloud.google.com/IAMPolicy #10725

Conversation

vgelot
Copy link
Contributor

@vgelot vgelot commented Sep 28, 2022

Add feature for iam.cnrm.cloud.google.com - IAMPolicy

Signed-off-by: Vincent <vincent.gelot@akeneo.com>
@vgelot vgelot force-pushed the feat-iam.cnrm.cloud.google.com-IAMPolicy branch from 77544c7 to 79b5883 Compare September 28, 2022 08:57
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 45.68% // Head: 45.68% // No change to project coverage 👍

Coverage data is based on head (79b5883) compared to base (f3f7334).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10725   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         236      236           
  Lines       28668    28668           
=======================================
  Hits        13097    13097           
  Misses      13779    13779           
  Partials     1792     1792           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev changed the title feat - Add feature for iam.cnrm.cloud.google.com - IAMPolicy feat: add health checks for iam.cnrm.cloud.google.com/IAMPolicy Oct 1, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @vgelot!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 1, 2022 00:02
@crenshaw-dev crenshaw-dev merged commit fc6d092 into argoproj:master Oct 1, 2022
@vgelot vgelot deleted the feat-iam.cnrm.cloud.google.com-IAMPolicy branch October 3, 2022 16:59
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
…proj#10725)

Signed-off-by: Vincent <vincent.gelot@akeneo.com>

Signed-off-by: Vincent <vincent.gelot@akeneo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants