increase liveness timeout

[cleverhu]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 45.67% // Head: 45.68% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4a94cad) compared to base (441b583).
Patch has no changes to coverable lines.

❗ Current head 4a94cad differs from pull request most recent head 3e26a6d. Consider uploading reports for the commit 3e26a6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10730      +/-   ##
==========================================
+ Coverage   45.67%   45.68%   +0.01%     
==========================================
  Files         236      236              
  Lines       28698    28668      -30     
==========================================
- Hits        13107    13097      -10     
+ Misses      13799    13779      -20     
  Partials     1792     1792              

Impacted Files	Coverage Δ
cmd/util/applicationset.go	0.00% <0.00%> (-19.24%)	⬇️
util/dex/dex.go	57.14% <0.00%> (-1.48%)	⬇️
server/application/application.go	27.93% <0.00%> (-1.06%)	⬇️
pkg/apis/application/v1alpha1/app_project_types.go	61.16% <0.00%> (-0.35%)	⬇️
server/badge/badge.go	84.28% <0.00%> (ø)
cmpserver/plugin/config.go	29.16% <0.00%> (ø)
controller/metrics/metrics.go	80.13% <0.00%> (ø)
util/settings/settings.go	51.36% <0.00%> (+0.11%)	⬆️
...cationset/controllers/applicationset_controller.go	56.75% <0.00%> (+0.11%)	⬆️
cmd/argocd/commands/app.go	19.01% <0.00%> (+0.50%)	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jannfis]

Hey @cleverhu - if you want to change something in the installation manifests, you have to edit the kustomize sources (e.g. here:

argo-cd/manifests/base/repo-server/argocd-repo-server-deployment.yaml

Line 149 in 1944141

livenessProbe:

), then run make manifests and commit all changes to your PR.

[cleverhu]

Hey @cleverhu - if you want to change something in the installation manifests, you have to edit the kustomize sources (e.g. here:

argo-cd/manifests/base/repo-server/argocd-repo-server-deployment.yaml

Line 149 in 1944141

livenessProbe:

), then run make manifests and commit all changes to your PR.

ok,thanks

[crenshaw-dev]

@cleverhu can you explain the importance of this change and why it should be made upstream instead of applied for individual deployments?

[cleverhu]

can you explain the importance of this change and why it should be made upstream instead of applied for individual deployments?

In my practical use, I have encountered the problem that single-copy server often restarts. If I remove liveness, it will not restart again. Therefore, the default timeout of 1 second is not very reasonable. borrowed from the company's internal projects and the practices of some open source communities, so it should be reasonable to set a longer timeout to prevent the container from restarting.

[crenshaw-dev]

I think this is reasonable. Thanks @cleverhu!