Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: read appset #10743

Merged
merged 1 commit into from Sep 30, 2022
Merged

tests: read appset #10743

merged 1 commit into from Sep 30, 2022

Conversation

emirot
Copy link
Contributor

@emirot emirot commented Sep 29, 2022

Add unit test for readappset

Signed-off-by: emirot <emirot.nolan@gmail.com>
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 45.68% // Head: 45.70% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c6c121b) compared to base (1944141).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10743      +/-   ##
==========================================
+ Coverage   45.68%   45.70%   +0.01%     
==========================================
  Files         236      236              
  Lines       28668    28668              
==========================================
+ Hits        13097    13102       +5     
+ Misses      13779    13772       -7     
- Partials     1792     1794       +2     
Impacted Files Coverage Δ
cmd/util/applicationset.go 19.23% <0.00%> (+19.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emirot!

@crenshaw-dev crenshaw-dev merged commit 3cdde8b into argoproj:master Sep 30, 2022
@emirot emirot deleted the test_appset branch October 3, 2022 01:57
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
Signed-off-by: emirot <emirot.nolan@gmail.com>

Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants