chore: upgrade dex to v2.32.1-distroless #10746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Codecov ReportBase: 45.68% // Head: 45.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10746 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 236 236
Lines 28668 28668
=======================================
Hits 13097 13097
Misses 13779 13779
Partials 1792 1792 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
| @@ -406,7 +406,7 @@ jobs: | |||
| git config --global user.email "john.doe@example.com" | |||
| - name: Pull Docker image required for tests | |||
| run: | | |||
| docker pull quay.io/dexidp/dex:v2.25.0 | |||
| docker pull ghcr.io/dexidp/dex:v2.32.1-distroless | |||
crenshaw-dev
added
cherry-pick/2.2
crenshaw-dev
approved these changes
Sep 30, 2022
crenshaw-dev
added a commit
that referenced
this pull request
Sep 30, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Sep 30, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Sep 30, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picked onto release-2.2 for 2.2.13, release-2.3 for 2.3.8, and release-2.4 for 2.4.13. |
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* chore: upgrade dex to v2.32.1-distroless Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * Retrigger CI pipeline Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * Retrigger CI pipeline Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Argo CD version 2.5/master uses
ghcr.io/dexidp/dex:v2.32.0-distrolesswhile 2.2-4.x useghcr.io/dexidp/dex:v2.32.0. The non distroless containers contain a few vulnerabilities at the container level.I created an issue upstream and they agreed to release dex:v2.32.1 which is now available and fixes these vulnerabilities. However they normally only patch the latest 2 versions. I would recommend that we switch to the distroless images.
Unfortunately at this time we cannot upgrade to dex:v2.33.x or dex:v2.34.x, please see #10617
Please consider cherry picking into 2.4, 2.3, and 2.2.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: