Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo for SyncStatusCodeOutOfSync comment #10748

Merged
merged 1 commit into from Sep 30, 2022

Conversation

elliotxx
Copy link
Contributor

Signed-off-by: 杨英明 951376975@qq.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: 杨英明 <951376975@qq.com>
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 45.68% // Head: 45.68% // No change to project coverage 👍

Coverage data is based on head (783c1ff) compared to base (1944141).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10748   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         236      236           
  Lines       28668    28668           
=======================================
  Hits        13097    13097           
  Misses      13779    13779           
  Partials     1792     1792           
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 54.84% <ø> (ø)
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elliotxx!

@crenshaw-dev crenshaw-dev merged commit 5e1eb5c into argoproj:master Sep 30, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
Signed-off-by: 杨英明 <951376975@qq.com>

Signed-off-by: 杨英明 <951376975@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants