Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: system level extensions #10758

Merged
merged 7 commits into from Oct 3, 2022
Merged

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Sep 30, 2022

Example extension:

((window) => {
  const component = () => {
    return React.createElement(
      "div",
      { style: { padding: "10px" } },
      "Hello World"
    );
  };
  window.extensionsAPI.registerSidebarExtension(
    component,
    "Test Ext",
    "/hello",
    "fa-flask"
  );
})(window);

CleanShot 2022-09-30 at 09 49 20@2x

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt September 30, 2022 16:49
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 45.67% // Head: 45.67% // No change to project coverage 👍

Coverage data is based on head (b074bd7) compared to base (76fe1d5).
Patch has no changes to coverable lines.

❗ Current head b074bd7 differs from pull request most recent head 5163d25. Consider uploading reports for the commit 5163d25 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10758   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files         236      236           
  Lines       28699    28699           
=======================================
  Hits        13108    13108           
  Misses      13799    13799           
  Partials     1792     1792           
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze changed the title feat: sidebar extensions feat: system level extensions Oct 3, 2022
ui/src/app/app.tsx Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
ui/src/app/app.tsx Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt October 3, 2022 20:43
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apparently is fixes #10780 as well

image

@alexmt alexmt enabled auto-merge (squash) October 3, 2022 21:37
@alexmt alexmt disabled auto-merge October 3, 2022 21:41
@alexmt alexmt enabled auto-merge (squash) October 3, 2022 21:43
@alexmt alexmt merged commit d211113 into argoproj:master Oct 3, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* feat: sidebar extensions

Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants