Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused import #10773

Merged
merged 2 commits into from Oct 4, 2022
Merged

Conversation

crenshaw-dev
Copy link
Collaborator

Trying to get rid of the annoying CI error.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 45.65% // Head: 45.67% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0288019) compared to base (202efb2).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10773      +/-   ##
==========================================
+ Coverage   45.65%   45.67%   +0.01%     
==========================================
  Files         236      236              
  Lines       28702    28699       -3     
==========================================
+ Hits        13104    13108       +4     
+ Misses      13804    13799       -5     
+ Partials     1794     1792       -2     
Impacted Files Coverage Δ
util/git/client.go 48.64% <66.66%> (-0.53%) ⬇️
cmd/argocd/commands/app.go 18.50% <0.00%> (-0.20%) ⬇️
server/application/application.go 28.98% <0.00%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@alexmt alexmt merged commit 7d81318 into argoproj:master Oct 4, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* chore: remove unused import

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants