New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Dex to 2.35.0 #10775
chore: upgrade Dex to 2.35.0 #10775
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 45.65% // Head: 45.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10775 +/- ##
==========================================
+ Coverage 45.65% 45.67% +0.01%
==========================================
Files 236 236
Lines 28702 28699 -3
==========================================
+ Hits 13104 13108 +4
+ Misses 13804 13799 -5
+ Partials 1794 1792 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for your prompt response
Just for a paper trail: this addresses GHSA-vh7g-p26c-j2cw for us. Argo CD configures the bundled Dex instance with a public client to be used by the |
* chore: upgrade dex to v2.35.0 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * upgrade github workflow too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: upgrade dex to v2.35.0 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * upgrade github workflow too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: upgrade dex to v2.35.0 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * upgrade github workflow too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Cherry-picked onto release-2.2 for 2.2.13, release-2.3 for 2.3.8, and release-2.4 for 2.4.13. |
Here when we can expect argocd dex server image will get updated to 2.35.0 from 2.32.0? - https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml#:~:text=image%3A%20ghcr.io/dexidp/dex%3Av2.32.0. |
@mayurwaghmode I failed to update the The manifest looks correct now: https://github.com/argoproj/argo-cd/blob/stable/manifests/install.yaml#L9767 I think the raw response must be cached, because it still hasn't updated. Hopefully that'll change in a few minutes. |
Thanks @crenshaw-dev :) |
* chore: upgrade dex to v2.35.0 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * upgrade github workflow too Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Supersedes #10617
Closes #10615