Add support for apple sillicon build machines #10777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the docker image on my M1 laptop, I noticed the produced builds are not usable in our Kubernetes cluster (running on x86 nodes). By passing the DOCKER_PLATFORM build argument to `docker build` I am able to overcome this and build x86 images locally. Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
zachaller
reviewed
Oct 3, 2022
Codecov ReportBase: 45.67% // Head: 45.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10777 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 236 236
Lines 28699 28699
=======================================
Hits 13108 13108
Misses 13799 13799
Partials 1792 1792 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
It is only used to produce app/dist, not relevant Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
zachaller
approved these changes
Oct 4, 2022
crenshaw-dev
approved these changes
Oct 4, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* Add support for apple sillicon build machines When building the docker image on my M1 laptop, I noticed the produced builds are not usable in our Kubernetes cluster (running on x86 nodes). By passing the DOCKER_PLATFORM build argument to `docker build` I am able to overcome this and build x86 images locally. Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Hardcode platform in dev build (same as we hardcode GOOS and GOARCH) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Drop platform from build-ui target It is only used to produce app/dist, not relevant Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the docker image on my M1 laptop, I noticed the produced builds are not usable in our Kubernetes cluster (running on x86 nodes).
By passing the DOCKER_PLATFORM build argument to
docker buildI am able to overcome this and build x86 images locally.Tested it with:
Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: