Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New sidebar icons are missing margin #10794

Merged
merged 1 commit into from Oct 5, 2022

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Oct 5, 2022

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Fixes #10793

image

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from rbreeze October 5, 2022 03:10
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 45.67% // Head: 45.66% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (df04158) compared to base (f724773).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10794      +/-   ##
==========================================
- Coverage   45.67%   45.66%   -0.02%     
==========================================
  Files         236      236              
  Lines       28699    28699              
==========================================
- Hits        13108    13104       -4     
- Misses      13799    13802       +3     
- Partials     1792     1793       +1     
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 33ef0b9 into argoproj:master Oct 5, 2022
@alexmt alexmt deleted the icons-margin branch October 5, 2022 04:22
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar icons are missing margin
2 participants