fix: add applicationset to crds generated by gen-crd-spec

[richardjennings]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[crenshaw-dev]

Ishita had previously consolidated the Application and ApplicationSet CRD codegen logic. In doing so, we lost the maxDescLen=0 flag on controller-gen.

-func getCustomResourceDefinitions() map[string]*extensionsobj.CustomResourceDefinition {
+func getCRDApplicationset() map[string]*extensionsobj.CustomResourceDefinition {
 	crdYamlBytes, err := exec.Command(
 		"controller-gen",
-		"paths=./pkg/apis/application/...",
-		"crd:trivialVersions=true",
-		"crd:crdVersions=v1",
+		"paths=./pkg/apis/applicationset/...",
+		"crd:crdVersions=v1,maxDescLen=0",
 		"output:crd:stdout",
 	).Output()
 	checkErr(err)

I'm not sure what the proper fix is. We're currently using this one controller-gen command to generate all the CRDs, since they're all located in the same directory.

I wonder if controller-gen takes a glob for the paths param. If so, we could maybe use one controller-gen command (with maxDescLen set) for the ApplicationSet CRD and another invocation for the rest.

Alternatively, we could add a post-processing step to strip the description fields from the AppliationSet CRD.

[codecov]

Codecov Report

Base: 45.67% // Head: 45.67% // No change to project coverage 👍

Coverage data is based on head (a31eb52) compared to base (d8cb04e).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10833   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files         236      236           
  Lines       28697    28697           
=======================================
  Hits        13106    13106           
  Misses      13799    13799           
  Partials     1792     1792           

Impacted Files	Coverage Δ
util/settings/settings.go	51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[crenshaw-dev]

Nicely done, thanks @richardjennings!

[crenshaw-dev]

Cherry-picked onto release-2.4 for 2.4.15 and release-2.5 for 2.5.0-rc1.

[crenshaw-dev]

Reverted cherry-pick onto 2.4. Doesn't make sense for it to be there, because the CRD generation changes didn't happen until 2.5. :-)