Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap error objects to include context (#10592) #10859

Merged
merged 4 commits into from Oct 9, 2022

Conversation

nirsht
Copy link
Contributor

@nirsht nirsht commented Oct 8, 2022

Signed-off-by: Nir Shtein 89006520+nirsht@users.noreply.github.com

nirsht and others added 2 commits October 8, 2022 20:17
Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
@nirsht
Copy link
Contributor Author

nirsht commented Oct 8, 2022

This PR is related to this issue #10592

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 45.68% // Head: 45.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0336462) compared to base (cbfcb19).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10859   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         236      236           
  Lines       28698    28695    -3     
=======================================
  Hits        13110    13110           
+ Misses      13796    13793    -3     
  Partials     1792     1792           
Impacted Files Coverage Δ
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)
cmd/argocd/commands/app.go 18.50% <0.00%> (ø)
cmd/argocd/commands/common.go 70.58% <0.00%> (ø)
cmd/argocd/commands/project.go 0.00% <0.00%> (ø)
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev changed the title Wrap error objects to include context chore: wrap error objects to include context (#10592) Oct 8, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nitpicks. :-)

cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved
cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved
cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved
cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved
cmd/argocd/commands/admin/cluster.go Outdated Show resolved Hide resolved
cmd/argocd/commands/app.go Outdated Show resolved Hide resolved
cmd/argocd/commands/project.go Outdated Show resolved Hide resolved
cmd/argocd/commands/project.go Outdated Show resolved Hide resolved
Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @nirsht!

@crenshaw-dev crenshaw-dev merged commit 2833be8 into argoproj:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants