New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: wrap error objects to include context (#10592) #10871
Conversation
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
fa57f44
to
39005f8
Compare
This PR is related to this issue - #10592 |
Codecov ReportBase: 45.62% // Head: 45.62% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10871 +/- ##
=======================================
Coverage 45.62% 45.62%
=======================================
Files 236 236
Lines 28699 28699
=======================================
Hits 13093 13093
Misses 13805 13805
Partials 1801 1801
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aimanfatima! Just wording nitpicks. Golang also has a convention of lowercase first letters in error messages. I don't know why. :-P
Signed-off-by: Aiman Fatima <aimanfatimadl@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aimanfatima!
Signed-off-by: Aiman Fatima aimanfatimadl@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: