feat: Shared custom health check for multiple resources (#4212) #10885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Signed-off-by: reggie <reginakagan@gmail.com>
Codecov ReportBase: 45.60% // Head: 45.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10885 +/- ##
==========================================
+ Coverage 45.60% 45.61% +0.01%
==========================================
Files 237 237
Lines 28914 28922 +8
==========================================
+ Hits 13185 13193 +8
Misses 13913 13913
Partials 1816 1816
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ated docs Signed-off-by: reggie <reginakagan@gmail.com>
…ated docs Signed-off-by: reggie <reginakagan@gmail.com>
…ated docs Signed-off-by: reggie <reginakagan@gmail.com>
|
@crenshaw-dev WDYT? |
crenshaw-dev
requested changes
Oct 21, 2022
…rror Signed-off-by: reggie <reginakagan@gmail.com>
5 tasks
crenshaw-dev
requested changes
Nov 8, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
… (argoproj#10885) * Kind wildcard support in health customizations Signed-off-by: reggie <reginakagan@gmail.com> * Updated health customizations docs to using the correct field with a / Signed-off-by: reggie <reginakagan@gmail.com> * Updated health customizations docs to using the correct field with a / Signed-off-by: reggie <reginakagan@gmail.com> * Document resource kind wildcard for custom health check Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Removed code duplication and returned an empty string instead of an error Signed-off-by: reggie <reginakagan@gmail.com> Signed-off-by: reggie <reginakagan@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Did this feature get support for wildcards in the group also? Like, |
|
Yeah, I will update the docs to state it clearly
…On Wed, Dec 21, 2022, 09:09 Kerwood ***@***.***> wrote:
Did this feature get support for wildcards in the group also? Like,
*.aws.crossplane.io/*:
health.lua: |
...
—
Reply to this email directly, view it on GitHub
<#10885 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVDWBFRIYONKZJ3PVATABDWOKUKZANCNFSM6AAAAAARBOJSYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Awesome.. Thank you developing this feature :) |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
… (argoproj#10885) * Kind wildcard support in health customizations Signed-off-by: reggie <reginakagan@gmail.com> * Updated health customizations docs to using the correct field with a / Signed-off-by: reggie <reginakagan@gmail.com> * Updated health customizations docs to using the correct field with a / Signed-off-by: reggie <reginakagan@gmail.com> * Document resource kind wildcard for custom health check Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Implemented wildcard * support in API Group and Resource Kind and updated docs Signed-off-by: reggie <reginakagan@gmail.com> * Removed code duplication and returned an empty string instead of an error Signed-off-by: reggie <reginakagan@gmail.com> Signed-off-by: reggie <reginakagan@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: