Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap error objects to include context #10904

Merged
merged 2 commits into from Oct 12, 2022

Conversation

someOne404
Copy link
Contributor

@someOne404 someOne404 commented Oct 11, 2022

Signed-off-by: Jiayi Lu jiayi_lu@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Jiayi Lu <jiayi_lu@intuit.com>
@someOne404 someOne404 marked this pull request as ready for review October 11, 2022 22:16
@someOne404
Copy link
Contributor Author

This PR is related to #10592

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 45.62% // Head: 45.62% // No change to project coverage 👍

Coverage data is based on head (04cfcfb) compared to base (4583cca).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10904   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files         236      236           
  Lines       28699    28699           
=======================================
  Hits        13093    13093           
  Misses      13805    13805           
  Partials     1801     1801           
Impacted Files Coverage Δ
...cationset/controllers/applicationset_controller.go 56.63% <0.00%> (ø)
cmd/util/project.go 9.70% <0.00%> (ø)
util/webhook/webhook.go 65.27% <0.00%> (ø)
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@someOne404
Copy link
Contributor Author

@crenshaw-dev Do you mind taking a look? Really appreciate it!

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks @someOne404!

@crenshaw-dev crenshaw-dev merged commit b5d8d5a into argoproj:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants