chore: improve log in argo-cd/applicationset/generators/generator_spec_processor.go #10906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>
crenshaw-dev
requested changes
Oct 12, 2022
| @@ -28,7 +28,7 @@ type TransformResult struct { | |||
| func Transform(requestedGenerator argoprojiov1alpha1.ApplicationSetGenerator, allGenerators map[string]Generator, baseTemplate argoprojiov1alpha1.ApplicationSetTemplate, appSet *argoprojiov1alpha1.ApplicationSet, genParams map[string]interface{}) ([]TransformResult, error) { | |||
| selector, err := metav1.LabelSelectorAsSelector(requestedGenerator.Selector) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("error transforming spec generator: %w", err) | |||
There was a problem hiding this comment.
@karengineering could you add a fmt import to the top of this file?
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("error transforming spec generator: %w", err) | |
| return nil, fmt.Errorf("error parsing label selector: %w", err) |
I think this is a bit more specific to the error being throw.
There was a problem hiding this comment.
updated @crenshaw-dev
Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com>
…neering/argo-cd into wrap-error-generatorspec
Codecov ReportBase: 45.82% // Head: 45.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10906 +/- ##
==========================================
- Coverage 45.82% 45.62% -0.21%
==========================================
Files 236 236
Lines 28698 28699 +1
==========================================
- Hits 13150 13093 -57
- Misses 13738 13805 +67
+ Partials 1810 1801 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
approved these changes
Oct 13, 2022
10 tasks
nbjohnson
pushed a commit
to nbjohnson/argo-cd
that referenced
this pull request
Oct 18, 2022
…c_processor.go (argoproj#10906) * wrap error object to include context for generator_spec_processor.go Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com> * addressing PR comments Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com> Signed-off-by: Karengineering <49111213+karengineering@users.noreply.github.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karengineering 49111213+karengineering@users.noreply.github.com
Fix for #10592
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: