Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document metadata access for go-templated cluster generator #10929

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

No description provided.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review October 13, 2022 15:51
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 45.62% // Head: 45.62% // No change to project coverage 👍

Coverage data is based on head (aaa0452) compared to base (c99669e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10929   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files         236      236           
  Lines       28699    28699           
=======================================
  Hits        13093    13093           
  Misses      13805    13805           
  Partials     1801     1801           
Impacted Files Coverage Δ
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ashutosh16
Copy link
Contributor

LGTM

@leoluz leoluz merged commit 46ae472 into argoproj:master Nov 4, 2022
@crenshaw-dev crenshaw-dev deleted the document-appset-cluster-go-syntax branch November 4, 2022 13:03
crenshaw-dev added a commit that referenced this pull request Nov 4, 2022
…0929)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto release-2.5 for 2.5.2.

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
…goproj#10929)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
…goproj#10929)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants