Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logs #10933

Merged
merged 1 commit into from Oct 13, 2022
Merged

chore: improve error logs #10933

merged 1 commit into from Oct 13, 2022

Conversation

nprajilesh
Copy link
Contributor

@nprajilesh nprajilesh commented Oct 13, 2022

Note on DCO:

This PR is related to this issue #10592

Signed-off-by: Prajilesh <nprajilesh@gmail.com>
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 45.82% // Head: 45.62% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (fe31bd0) compared to base (ba10959).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10933      +/-   ##
==========================================
- Coverage   45.82%   45.62%   -0.21%     
==========================================
  Files         236      236              
  Lines       28698    28699       +1     
==========================================
- Hits        13150    13093      -57     
- Misses      13738    13805      +67     
+ Partials     1810     1801       -9     
Impacted Files Coverage Δ
controller/cache/cache.go 20.88% <0.00%> (ø)
util/github_app/repos.go 83.33% <0.00%> (ø)
server/application/application.go 27.89% <0.00%> (-1.12%) ⬇️
util/settings/settings.go 51.25% <0.00%> (ø)
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
pkg/apiclient/apiclient.go 1.25% <0.00%> (+0.15%) ⬆️
server/application/terminal.go 12.75% <0.00%> (+1.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @nprajilesh!

@crenshaw-dev crenshaw-dev merged commit 6e9e16e into argoproj:master Oct 13, 2022
nbjohnson pushed a commit to nbjohnson/argo-cd that referenced this pull request Oct 18, 2022
Signed-off-by: Prajilesh <nprajilesh@gmail.com>

Signed-off-by: Prajilesh <nprajilesh@gmail.com>
Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants