Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade actions/checkout to v3, i.e. Node.js 16 #10947

Merged
merged 2 commits into from Oct 19, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

@crenshaw-dev crenshaw-dev commented Oct 14, 2022

In response to the warning here: https://github.com/argoproj/argo-cd/actions/runs/3244579349

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

And here: https://github.com/argoproj/argo-cd/actions/runs/3229463955

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/setup-go, docker/setup-qemu-action, docker/setup-buildx-action, softprops/action-gh-release, docker/setup-buildx-action, actions/checkout

Unfortunately, there's no update for softprops/action-gh-release yet. softprops/action-gh-release#263

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev added cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Oct 14, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 45.82% // Head: 45.64% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (de0f476) compared to base (eb9d0a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10947      +/-   ##
==========================================
- Coverage   45.82%   45.64%   -0.19%     
==========================================
  Files         236      237       +1     
  Lines       28700    28719      +19     
==========================================
- Hits        13152    13108      -44     
- Misses      13738    13808      +70     
+ Partials     1810     1803       -7     
Impacted Files Coverage Δ
server/application/application.go 27.89% <0.00%> (-1.12%) ⬇️
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
cmd/argocd/commands/account.go 0.00% <0.00%> (ø)
cmd/argocd/commands/bcrypt.go 76.47% <0.00%> (ø)
pkg/apiclient/apiclient.go 1.25% <0.00%> (+0.15%) ⬆️
server/application/terminal.go 12.75% <0.00%> (+1.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev changed the title chore: updgrade actions/checkout to v3, i.e. Node.js 16 chore: upgrade actions/checkout to v3, i.e. Node.js 16 Oct 14, 2022
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 8a71b8a into argoproj:master Oct 19, 2022
@crenshaw-dev crenshaw-dev deleted the upgrade-actions-checkout branch October 19, 2022 14:32
crenshaw-dev added a commit that referenced this pull request Oct 19, 2022
* chore: updgrade actions/checkout to v3, i.e. Node.js 16

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more node 12

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Oct 19, 2022
* chore: updgrade actions/checkout to v3, i.e. Node.js 16

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more node 12

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Oct 19, 2022
* chore: updgrade actions/checkout to v3, i.e. Node.js 16

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more node 12

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Oct 19, 2022
* chore: updgrade actions/checkout to v3, i.e. Node.js 16

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* more node 12

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto release-2.2 for 2.2.16, release-2.3 for 2.3.11, release-2.4 for 2.4.16, and release-2.5 for 2.5.0-rc4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants