chore: sign checksum file for release binaries #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
|
Once merged we can |
Codecov ReportBase: 45.83% // Head: 45.83% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10963 +/- ##
=======================================
Coverage 45.83% 45.83%
=======================================
Files 237 237
Lines 28720 28720
=======================================
Hits 13165 13165
Misses 13742 13742
Partials 1813 1813
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
lgtm, thanks @34fathombelow!
Aside, I wonder if it would be worth it to get a checksum of the sbom and sign that as well.
|
I expect to push some releases Monday, so this will get tested then. |
crenshaw-dev
added
cherry-pick/2.2
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 17, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 17, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 17, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
|
Cherry-picked onto release-2.2 for 2.2.15, release-2.3 for 2.3.10, release-2.4 for 2.4.15, and release-2.5 for 2.5.0-rc3. |
crenshaw-dev
added a commit
that referenced
this pull request
Oct 18, 2022
* fix: Resource list loading slowly due to Sync Wave sorting (#10932) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: fix wrong annotation in function (#10923) Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * feat: add bcrypt support for argocd CLI (#10934) * Adding bcrypt support for argocd CLI Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Fixing linter issues Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Nesting bcrypt under account instead of admin Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Removing admin bcrypt docs Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Update docs/faq.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Co-authored-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: implement signed images (#10925) * consolidate checksums into one file Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * sign container images Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * sign container images Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * remove id-token permissions Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: delete old snyk reports (#10938) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: rewording of misleading message (#10407) Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: delete old snyk reports, 2nd attempt (#10950) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: wrap error objects to include context (#10592) (#10940) Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * fix: Use os.PathSeparator instead of hard-coded string to resolve local file paths (#10945) (#10946) fix: Use os.PathSeparator instead of hard-coded string to resolve local file paths (#10945) (#10946) Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: covered error log in controllers Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: sign checksums file for release binaries (#10963) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * [Bot] Update Snyk reports (#10953) Signed-off-by: CI <ci@argoproj.com> Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * feat: make applicationset controller configurable in argocd-cmd-params (#10961) Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * docs: message is no longer truncated (#10962) Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * fix: addressed review comments Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: CI <ci@argoproj.com> Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Adam <wjw3323@live.com> Co-authored-by: Amey Totawar <ameytotawar@gmail.com> Co-authored-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Smriti Prakash <smriti_prakash@intuit.com> Co-authored-by: 34FathomBelow <34fathombelow@protonmail.com> Co-authored-by: Ryan Talbot <4523072+RyanTalbot@users.noreply.github.com> Co-authored-by: nsahai8 <ns8gupta@gmail.com> Co-authored-by: Chris Davis <chris@codeflow.org.uk> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Shawn Toffel <shawn.toffel+github@gmail.com>
nbjohnson
pushed a commit
to nbjohnson/argo-cd
that referenced
this pull request
Oct 18, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
nbjohnson
pushed a commit
to nbjohnson/argo-cd
that referenced
this pull request
Oct 18, 2022
* fix: Resource list loading slowly due to Sync Wave sorting (argoproj#10932) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: fix wrong annotation in function (argoproj#10923) Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * feat: add bcrypt support for argocd CLI (argoproj#10934) * Adding bcrypt support for argocd CLI Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Fixing linter issues Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Nesting bcrypt under account instead of admin Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Removing admin bcrypt docs Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> * Update docs/faq.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Co-authored-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: implement signed images (argoproj#10925) * consolidate checksums into one file Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * sign container images Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * sign container images Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * remove id-token permissions Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: delete old snyk reports (argoproj#10938) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: rewording of misleading message (argoproj#10407) Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: delete old snyk reports, 2nd attempt (argoproj#10950) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: wrap error objects to include context (argoproj#10592) (argoproj#10940) Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * fix: Use os.PathSeparator instead of hard-coded string to resolve local file paths (argoproj#10945) (argoproj#10946) fix: Use os.PathSeparator instead of hard-coded string to resolve local file paths (argoproj#10945) (argoproj#10946) Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: improve error logs Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: covered error log in controllers Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * chore: sign checksums file for release binaries (argoproj#10963) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * [Bot] Update Snyk reports (argoproj#10953) Signed-off-by: CI <ci@argoproj.com> Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * feat: make applicationset controller configurable in argocd-cmd-params (argoproj#10961) Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * docs: message is no longer truncated (argoproj#10962) Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> * fix: addressed review comments Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Smriti Prakash <smriti_prakash@intuit.com> Signed-off-by: wujunwei <wjw3323@live.com> Signed-off-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Signed-off-by: Amey Totawar <ameytotawar@gmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Ryan Talbot <ryan-talbot@outlook.com> Signed-off-by: Niharika <ns8gupta@gmail.com> Signed-off-by: Niharika <niharika_sahai@intuit.com> Signed-off-by: CI <ci@argoproj.com> Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: Shawn Toffel <shawn.toffel@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Adam <wjw3323@live.com> Co-authored-by: Amey Totawar <ameytotawar@gmail.com> Co-authored-by: Amey Totawar <ameysanjaykumar_totawar@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Smriti Prakash <smriti_prakash@intuit.com> Co-authored-by: 34FathomBelow <34fathombelow@protonmail.com> Co-authored-by: Ryan Talbot <4523072+RyanTalbot@users.noreply.github.com> Co-authored-by: nsahai8 <ns8gupta@gmail.com> Co-authored-by: Chris Davis <chris@codeflow.org.uk> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Shawn Toffel <shawn.toffel+github@gmail.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
This PR signs the checksum file for release binaries. Also removes adding a signature to the Dockerhub image since we know Quay is working well. We can add this back at a later time. Once we know if the images should still be pushed Dockerhub.
Follow up PR coming soon. It will contain user documentation on how to verify the signatures for containers and release notes containing our public key.