New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release signature documentation #10967
chore: release signature documentation #10967
Conversation
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Codecov ReportBase: 45.63% // Head: 45.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #10967 +/- ##
=======================================
Coverage 45.63% 45.63%
=======================================
Files 237 237
Lines 28721 28721
=======================================
Hits 13108 13108
Misses 13809 13809
Partials 1804 1804 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @34fathombelow! Nitpicks only. :-)
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* chore: release signature documentation Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fixed typos Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fixed requested changes Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
I'll leave the docs for 2.5 only. The conflicts were gonna be a pain, and 2.5 is going to be GA soon anyway. |
* chore: release signature documentation Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fixed typos Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fixed requested changes Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: