Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller/hearth: decreased indent level in setApplicationHealth #10980

Merged
merged 1 commit into from Oct 19, 2022

Conversation

proggga
Copy link
Contributor

@proggga proggga commented Oct 18, 2022

#hacktoberfest

found a place where we can decrease indent level and simplified code

Signed-off-by: Mikhail Fesenko <proggga@gmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 45.85% // Head: 45.84% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4ee6c6c) compared to base (a7e8d97).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10980      +/-   ##
==========================================
- Coverage   45.85%   45.84%   -0.01%     
==========================================
  Files         237      237              
  Lines       28727    28728       +1     
==========================================
- Hits        13172    13171       -1     
- Misses      13742    13743       +1     
- Partials     1813     1814       +1     
Impacted Files Coverage Δ
controller/health.go 88.88% <84.61%> (-5.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it. Thanks @proggga!

@crenshaw-dev crenshaw-dev merged commit 5d9d53c into argoproj:master Oct 19, 2022
@proggga proggga deleted the decrease_inheritance_level branch October 19, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants