Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention that OCI helm does not support version ranges #11026

Merged
merged 2 commits into from Oct 21, 2022
Merged

docs: mention that OCI helm does not support version ranges #11026

merged 2 commits into from Oct 21, 2022

Conversation

alexef
Copy link
Member

@alexef alexef commented Oct 21, 2022

Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@alexef
docs: mention that OCI helm does not support version ranges
d291b53 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
@alexef
Apply suggestions from code review
534ab5e 
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
crenshaw-dev
crenshaw-dev approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alexef!

@crenshaw-dev crenshaw-dev added cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch labels Oct 21, 2022
@crenshaw-dev crenshaw-dev merged commit fdd2e98 into argoproj:release-2.5 Oct 21, 2022
crenshaw-dev pushed a commit that referenced this pull request Oct 21, 2022
@alexef @crenshaw-dev
docs: mention that OCI helm does not support version ranges (#11026)
e416129 
* docs: mention that OCI helm does not support version ranges

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Apply suggestions from code review

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 21, 2022
@alexef @crenshaw-dev
docs: mention that OCI helm does not support version ranges (#11026)
fbf38d1 
* docs: mention that OCI helm does not support version ranges

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Apply suggestions from code review

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 21, 2022
@alexef @crenshaw-dev
docs: mention that OCI helm does not support version ranges (#11026)
57edeec 
* docs: mention that OCI helm does not support version ranges

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Apply suggestions from code review

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Mar 7, 2023
@alexef @sujeilyfonseca
docs: mention that OCI helm does not support version ranges (argoproj…
f415e82 
…#11026)

* docs: mention that OCI helm does not support version ranges

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

* Apply suggestions from code review

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexef @crenshaw-dev