New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate import statements from es5 to es6 #11042
Conversation
Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com>
Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com>
aceb787
to
74aded9
Compare
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11042 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 237 237
Lines 28914 28914
=======================================
Hits 13185 13185
Misses 13913 13913
Partials 1816 1816 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@crenshaw-dev Can you please help with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change needed. Thanks @trishnakalita660!
package-lock.json
Outdated
@@ -0,0 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trishnakalita660 can you delete this file? I think it was accidentally created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
…akalita660@gmail.com Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com>
Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com>
aa853d2
to
3819c02
Compare
Hi @crenshaw-dev , Can you please review and help me in merging this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trishnakalita660!
* Migrating import syntax from es5 to es6 Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com> * Migrating import syntax from es5 to es6 Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com> * Run build, test and lint UI code Signed-off-by: Trishna Kalita trishnakalita660@gmail.com Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com> * Removed package-lock.json Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com> Signed-off-by: trishnakalita660 <trishnakalita660@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Trishna Kalita trishnakalita660@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: