Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(user-guide): update link to Helm hooks documentation #11045

Merged
merged 1 commit into from Nov 7, 2022

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented Oct 24, 2022

Just a quick update to point the link for Helm hooks documentation to the Helm documentation page instead of an outdated branch in helm/helm.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Lukas Grossar <lukas.grossar@adfinis.com>
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 45.60% // Head: 45.60% // No change to project coverage 👍

Coverage data is based on head (0f5e7a6) compared to base (309654c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11045   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         237      237           
  Lines       28914    28914           
=======================================
  Hits        13185    13185           
  Misses      13913    13913           
  Partials     1816     1816           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blakepettersson
Copy link
Member

LGTM 👍

@crenshaw-dev crenshaw-dev merged commit 9bada88 into argoproj:master Nov 7, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
…1045)

Signed-off-by: Lukas Grossar <lukas.grossar@adfinis.com>

Signed-off-by: Lukas Grossar <lukas.grossar@adfinis.com>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
…1045)

Signed-off-by: Lukas Grossar <lukas.grossar@adfinis.com>

Signed-off-by: Lukas Grossar <lukas.grossar@adfinis.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants