Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge generator where a generator can reference items of another one #11054

Open
jpcosal opened this issue Oct 25, 2022 · 1 comment
Open

Merge generator where a generator can reference items of another one #11054

jpcosal opened this issue Oct 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jpcosal
Copy link

jpcosal commented Oct 25, 2022

Summary

Very much like what's been added for the Matrix generator #9080, it would be nice to have the same for the Merge generator.
Something like

  generators:
    - merge:
        mergeKeys:
          - name
        generators:
          - git:
              repoURL: https://github.com/my_org/my_repo.git
              revision: my_revision
              files:
                - path: path/*.yaml
          - git:
              repoURL: https://github.com/my_org/my_repo2.git
              revision: '{{sha}}'
              files:
                - path: path2/**/file.yaml

Notice the {{sha}} reference in the second generator.

cf original issue for merge generator argoproj/applicationset#530

Motivation

We have the following use case:

  • Repo my_repo contains a collection of files corresponding to a list of services to deploy. File content is basically the sha/tag of the container image to use to deploy corresponding service
  • Repo my_repo2 contains the deployment resources/manifests of the services. We want to use the version corresponding to the sha/tag defined above. We need to extract some info from the repo to create the actual ArgoCD apps.

Proposal

Some kind of code changes as what was done in #9080

@jpcosal jpcosal added the enhancement New feature or request label Oct 25, 2022
@leotomas837
Copy link

Would be indeed very convenient, anything planned ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants