New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry to cluster generation for testing in hack folder #11067
Conversation
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11067 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 237 237
Lines 28914 28914
=======================================
Hits 13185 13185
Misses 13913 13913
Partials 1816 1816 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…goproj#11067) * Add retry for cluster generation Signed-off-by: Dan Garfield <dan@codefresh.io> * Switch to human readable count Signed-off-by: Dan Garfield <dan@codefresh.io> * fix logic Signed-off-by: Dan Garfield <dan@codefresh.io> * Add retry for cluster generation Signed-off-by: Dan Garfield <dan@codefresh.io> * remove superfluous if from previous iteration. Signed-off-by: Dan Garfield <dan@codefresh.io> * clean up code for final PR Signed-off-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Dan Garfield dan@codefresh.io
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
There are three very small changes to the resource generation
helm upgrade --install
incase there is an attempt at repair, not really important, just stylistically better.