Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to cluster generation for testing in hack folder #11067

Merged
merged 8 commits into from Oct 31, 2022

Conversation

todaywasawesome
Copy link
Contributor

Signed-off-by: Dan Garfield dan@codefresh.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • [n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

There are three very small changes to the resource generation

  1. Switch to helm upgrade --install incase there is an attempt at repair, not really important, just stylistically better.
  2. Add a few more debugging messages
  3. Add a retry to getting cluster credentials. This step fails pretty regularly just because the endpoint isn't quite ready yet.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 45.60% // Head: 45.60% // No change to project coverage 👍

Coverage data is based on head (de8eb06) compared to base (a765c14).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11067   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         237      237           
  Lines       28914    28914           
=======================================
  Hits        13185    13185           
  Misses      13913    13913           
  Partials     1816     1816           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
todaywasawesome and others added 2 commits October 31, 2022 08:59
Signed-off-by: Dan Garfield <dan@codefresh.io>
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev merged commit 9353328 into argoproj:master Oct 31, 2022
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
…goproj#11067)

* Add retry for cluster generation

Signed-off-by: Dan Garfield <dan@codefresh.io>

* Switch to human readable count

Signed-off-by: Dan Garfield <dan@codefresh.io>

* fix logic

Signed-off-by: Dan Garfield <dan@codefresh.io>

* Add retry for cluster generation

Signed-off-by: Dan Garfield <dan@codefresh.io>

* remove superfluous if from previous iteration.

Signed-off-by: Dan Garfield <dan@codefresh.io>

* clean up code for final PR

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants