New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(user-guide): Add doc for import argocd packages (#11041) #11096
Conversation
Signed-off-by: balajisa09 <balajisa09@gmail.com>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11096 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 237 237
Lines 28933 28933
=======================================
Hits 13194 13194
Misses 13922 13922
Partials 1817 1817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be up for writing a small section describing how to find the go.mod file for a given Argo CD version?
You'll also need to add this new file to mkdocs.yaml so it will appear in the table of contents.
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com>
Signed-off-by: balajisa09 <balajisa09@gmail.com>
Signed-off-by: balajisa09 <balajisa09@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few last tweaks.
Thanks again for this page! I was really helpful when I needed to use the Argo CD API client a couple days ago. https://github.com/crenshaw-dev/argocd-executor-plugin
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com>
@crenshaw-dev Happy to help. I have committed all your suggestions. Looking forward to contribute more. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @balajisa09!
* Add doc for argocd pkg import Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Add detailed solution Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update suggestions Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix code block Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa09 <balajisa09@gmail.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: balajisa09 <balajisa09@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Cherry-picked onto release-2.5 for 2.5.2. |
…argoproj#11096) * Add doc for argocd pkg import Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Add detailed solution Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update suggestions Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix code block Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa09 <balajisa09@gmail.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: balajisa09 <balajisa09@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…argoproj#11096) * Add doc for argocd pkg import Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Add detailed solution Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update suggestions Signed-off-by: balajisa09 <balajisa09@gmail.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> * Update docs/user-guide/import.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix code block Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: balajisa09 <balajisa09@gmail.com> Signed-off-by: balajisa <50614674+balajisa09@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: balajisa09 <balajisa09@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: balajisa09 balajisa09@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: