Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Pigment to list of users #11127

Merged
merged 1 commit into from Nov 8, 2022
Merged

docs: add Pigment to list of users #11127

merged 1 commit into from Nov 8, 2022

Conversation

busser
Copy link
Contributor

@busser busser commented Oct 31, 2022 •
edited

Fixes #11126.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@busser busser changed the title Allow Redis pods to make DNS queries to outside of cluster (fixes #11126) fix: Allow Redis pods to make DNS queries to outside of cluster (fixes #11126) Oct 31, 2022
@busser busser mentioned this pull request Oct 31, 2022
Closed
3 tasks
@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited

Codecov Report

Base: 45.60% // Head: 45.63% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6f663e2) compared to base (a765c14).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11127      +/-   ##
==========================================
+ Coverage   45.60%   45.63%   +0.03%     
==========================================
  Files         237      238       +1     
  Lines       28914    28953      +39     
==========================================
+ Hits        13185    13214      +29     
- Misses      13913    13920       +7     
- Partials     1816     1819       +3
Impacted Files Coverage Δ
cmpserver/plugin/plugin.go 47.91% <0.00%> (-1.37%) ⬇️
applicationset/utils/utils.go 80.35% <0.00%> (-0.63%) ⬇️
reposerver/repository/repository.go 60.88% <0.00%> (-0.23%) ⬇️
pkg/apis/application/v1alpha1/types.go 54.84% <0.00%> (ø)
controller/sync_namespace.go 85.00% <0.00%> (ø)
util/argo/resource_tracking.go 70.45% <0.00%> (+0.33%) ⬆️
controller/state.go 72.93% <0.00%> (+0.34%) ⬆️
controller/sync.go 55.21% <0.00%> (+1.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev
Copy link
Collaborator

I'm cool with it! CC @zachaller for his superior cloud knowledge. :-)

@crenshaw-dev
Copy link
Collaborator

Zach had some reservations but wants to do some testing. Will report back.

@busser
Copy link
Contributor Author

busser commented Nov 2, 2022

Sounds good. @zachaller if there's anything I can do to help, let me know.

@34fathombelow 34fathombelow mentioned this pull request Nov 3, 2022
Merged
@busser busser changed the title fix: Allow Redis pods to make DNS queries to outside of cluster (fixes #11126) docs: add Pigment to list of users Nov 4, 2022
@busser
Copy link
Contributor Author

busser commented Nov 4, 2022

This PR is superseded by #11176.

I removed the now unnecessary changes to the deployment manifests. All that remains is an update to the list of users. PR title updated accordingly.

crenshaw-dev
crenshaw-dev approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @busser!

@crenshaw-dev crenshaw-dev reopened this Nov 4, 2022
@crenshaw-dev
Copy link
Collaborator

Looked like checks got stuck. :-)

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) November 4, 2022 12:45
@busser
chore: add Pigment to list of users
6f663e2 
Signed-off-by: Arthur Busser <arthur.busser@gopigment.com>
auto-merge was automatically disabled November 4, 2022 13:43

Head branch was pushed to by a user without write access

@busser
Copy link
Contributor Author

busser commented Nov 7, 2022

@crenshaw-dev re-triggering CI made the checks pass 👌

@crenshaw-dev crenshaw-dev merged commit 1ae5aff into argoproj:master Nov 8, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
@busser @ashutosh16
chore: add Pigment to list of users (argoproj#11127)
ed4eb8e 
Signed-off-by: Arthur Busser <arthur.busser@gopigment.com>

Signed-off-by: Arthur Busser <arthur.busser@gopigment.com>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@busser @emirot
chore: add Pigment to list of users (argoproj#11127)
193c0e0 
Signed-off-by: Arthur Busser <arthur.busser@gopigment.com>

Signed-off-by: Arthur Busser <arthur.busser@gopigment.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@34fathombelow 34fathombelow 34fathombelow approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network policy egress rules break HA Redis on GKE with NodeLocal DNSCache
4 participants
@busser @crenshaw-dev @zachaller @34fathombelow