Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: debugging sidecar CMPs #11142

Merged
merged 2 commits into from Nov 4, 2022
Merged

Conversation

crenshaw-dev
Copy link
Collaborator

Documenting common errors.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev changed the title docs: debugging CMPs docs: debugging sidecar CMPs Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 45.60% // Head: 45.60% // No change to project coverage 👍

Coverage data is based on head (b7d9d55) compared to base (a773b1e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11142   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         237      237           
  Lines       28933    28933           
=======================================
  Hits        13194    13194           
  Misses      13922    13922           
  Partials     1817     1817           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

repo-server Pod so the plugin will pick up the changes. If you are using `:latest`, the Pod will always pull the new
image. If you're using a different, static tag, set `imagePullPolicy: Always` on the CMP's sidecar container.
3) CMP errors are cached by the repo-server in Redis. Restarting the repo-server Pod will not clear the cache. Always
do a "Hard Refresh" when actively developing a CMP so you have the latest output.
Copy link
Contributor

@arturhoo arturhoo Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially assumed that the --repo-cache-expiration would also work for this cache, but it turned out not to be the case. Do you know if this is expected or if it would be worth adding a new flag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. That ought to work. Do you have a test case showing that the manifests aren't expiring?

@lucj
Copy link

lucj commented Nov 2, 2022

@crenshaw-dev LGTM, very useful to know when building a plugin for the first time

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@leoluz leoluz enabled auto-merge (squash) November 4, 2022 13:01
@leoluz leoluz merged commit ac69e27 into argoproj:master Nov 4, 2022
@crenshaw-dev crenshaw-dev deleted the debugging-cmps branch November 4, 2022 14:44
crenshaw-dev added a commit that referenced this pull request Nov 4, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

Cherry-picked onto release-2.5 for 2.5.2.

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
sujeilyfonseca pushed a commit to sujeilyfonseca/argo-cd that referenced this pull request Mar 7, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants