feat: Add new admin command to print Argo CD initial password (11117) #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.63% // Head: 45.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11155 +/- ##
==========================================
- Coverage 45.63% 45.60% -0.04%
==========================================
Files 238 239 +1
Lines 28953 28973 +20
==========================================
Hits 13214 13214
- Misses 13920 13940 +20
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks @iam-veeramalla! One small grammar tweak.
Could you also update the quick start guide to reference this new command instead of the kubectl command?
|
|
||
| if initialPass, ok := secret.Data["password"]; ok { | ||
| fmt.Println(string(initialPass)) | ||
| fmt.Println("\n This password must be only used for first time login. We strongly recommend you to update the password using `argocd account update-password`.") |
There was a problem hiding this comment.
Suggested change
| fmt.Println("\n This password must be only used for first time login. We strongly recommend you to update the password using `argocd account update-password`.") | |
| fmt.Println("\n This password must be only used for first time login. We strongly recommend you update the password using `argocd account update-password`.") |
iam-veeramalla
force-pushed
the
addInitialPassword
branch
from
21eaae3
to
b2b18da
Compare
|
Can you run CLI codegen again? |
Sure, will do that tomorrow morning. |
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
force-pushed
the
addInitialPassword
branch
from
6a11c43
to
cda5c5a
Compare
|
My mac is giving me hard times in running the codegen and other make targets :( . Hope this commit will fix the failing CI. |
|
@crenshaw-dev got the code-gen working now. PTAL |
|
@crenshaw-dev just in case you missed my previous comment. Fixed the failing CI and rebased the code. |
crenshaw-dev
requested changes
Nov 4, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Nov 4, 2022
crenshaw-dev
reviewed
Nov 4, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
…argoproj#11155) * feat: Add new admin command to print Argo CD initial password (11117) Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * Update docs/getting_started.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update cmd/argocd/commands/admin/initial_password.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/user-guide/commands/argocd_admin_initial-password.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…argoproj#11155) * feat: Add new admin command to print Argo CD initial password (11117) Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * fix failing CI Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> * Update docs/getting_started.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update cmd/argocd/commands/admin/initial_password.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/user-guide/commands/argocd_admin_initial-password.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
|
I don't know if I'm missing something but, how is this helpful? if you ran |
|
@ofirshtrull , Before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iam-veeramalla abhishek.veeramalla@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Fixes #11117
Closes #11117