fix: templating keys in ApplicationSet (#11076) #11163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportBase: 45.60% // Head: 45.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11163 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 237 237
Lines 28914 28919 +5
=======================================
+ Hits 13185 13188 +3
- Misses 13913 13914 +1
- Partials 1816 1817 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hello, Thanks a lot for reactivity |
zachaller
approved these changes
Nov 3, 2022
|
Cherry-picked onto release-2.5 for 2.5.2. |
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11076