fix: upgrade redis-ha chart to 4.22.3, redis regression #11176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11176 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 237 237
Lines 28914 28914
=======================================
Hits 13185 13185
Misses 13913 13913
Partials 1816 1816
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
zachaller
approved these changes
Nov 3, 2022
34fathombelow
changed the title
|
Tested a sample of this fix on slack and worked well on our eks cluster. |
crenshaw-dev
pushed a commit
that referenced
this pull request
Nov 3, 2022
* chore: upgrade redis-ha chart to 4.22.3, redis regression Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix manifest Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix missing cidr Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix typo Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix typo Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
|
Cherry-picked onto release-2.5 for 2.5.2. |
5 tasks
|
Glad to see a fix for this! Well done 👏 👏 |
3 tasks
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* chore: upgrade redis-ha chart to 4.22.3, redis regression Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix manifest Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix missing cidr Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix typo Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * fix typo Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Supersedes #11127
Fixes #11126
Fixes split-brain-fix problem associated with pods going into a crashing loop. Also allows redis pods to make DNS queries outside the cluster.
Special thanks for the awesome people that provided reporting, logs, analysis, and testing.