Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amadeus in Users list #11177

Merged
merged 1 commit into from Nov 3, 2022

Conversation

Hariharasuthan99
Copy link
Contributor

@Hariharasuthan99 Hariharasuthan99 commented Nov 3, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 45.60% // Head: 45.60% // No change to project coverage 👍

Coverage data is based on head (6250332) compared to base (21731c9).
Patch has no changes to coverable lines.

❗ Current head 6250332 differs from pull request most recent head 5553302. Consider uploading reports for the commit 5553302 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11177   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         237      237           
  Lines       28914    28914           
=======================================
  Hits        13185    13185           
  Misses      13913    13913           
  Partials     1816     1816           
Impacted Files Coverage Δ
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iam-veeramalla
Copy link
Member

@Hariharasuthan99 can you please sign the commit using
git commit --amend --signoff

This will fix the failing DCO

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can override DCO for non-code changes. :-)

Thanks @Hariharasuthan99!

@crenshaw-dev crenshaw-dev merged commit c8cae4a into argoproj:master Nov 3, 2022
@Hariharasuthan99 Hariharasuthan99 deleted the 1a-in-users.md branch November 4, 2022 03:07
@Hariharasuthan99
Copy link
Contributor Author

Thank you! @crenshaw-dev

@Hariharasuthan99
Copy link
Contributor Author

Hariharasuthan99 commented Nov 4, 2022

@Hariharasuthan99 can you please sign the commit using git commit --amend --signoff

This will fix the failing DCO

Will follow this from the next PR onwards, Thank you! @iam-veeramalla

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
Co-authored-by: hraajeshwar <hariharasuthan.raajeshwar@amadeus.com>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Co-authored-by: hraajeshwar <hariharasuthan.raajeshwar@amadeus.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants