chore: add debug logs around CMP manifest generation #11185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturhoo
force-pushed
the
plugin-debug
branch
3 times, most recently
from
5602ef5
to
af29712
Compare
Codecov ReportBase: 45.61% // Head: 45.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11185 +/- ##
==========================================
- Coverage 45.61% 45.59% -0.02%
==========================================
Files 237 237
Lines 28920 28928 +8
==========================================
Hits 13191 13191
- Misses 13913 13921 +8
Partials 1816 1816
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
changed the title
crenshaw-dev
requested changes
Nov 3, 2022
added 2 commits
November 3, 2022 21:17
Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net>
Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net>
arturhoo
force-pushed
the
plugin-debug
branch
from
af29712
to
0bf11ab
Compare
crenshaw-dev
changed the title
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
* docs: note one single CMP per app Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> * cmp: debug logs around manifest handling Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net>
crenshaw-dev
pushed a commit
that referenced
this pull request
Dec 3, 2022
* docs: note one single CMP per app Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> * cmp: debug logs around manifest handling Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net>
|
Cherry-picked onto release-2.5 for 2.5.4. |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* docs: note one single CMP per app Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> * cmp: debug logs around manifest handling Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> Signed-off-by: emirot <emirot.nolan@gmail.com>
sujeilyfonseca
pushed a commit
to sujeilyfonseca/argo-cd
that referenced
this pull request
Mar 7, 2023
* docs: note one single CMP per app Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> * cmp: debug logs around manifest handling Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net> Signed-off-by: Artur Rodrigues <artur.rodrigues@lacework.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my conversation with @crenshaw-dev, adding:
I haven't found test cases for log statements, but I'd be happy to submit some manually produced evidence.