New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not mutate live when managed namespace enabled #11197
Conversation
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@crenshaw-dev and other possible reviewers: Once approved, please do not merge. I need to update gitops-engine dependency in this PR first. |
Codecov ReportBase: 45.63% // Head: 45.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11197 +/- ##
==========================================
- Coverage 45.63% 45.60% -0.04%
==========================================
Files 238 239 +1
Lines 28953 28969 +16
==========================================
- Hits 13214 13211 -3
- Misses 13920 13939 +19
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
* fix: do not mutate live when managed namespace enabled Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * remove trackingID from e2e test validation Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix e2e Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * remove unnecessary config Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
* fix: do not mutate live when managed namespace enabled Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * remove trackingID from e2e test validation Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix e2e Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * remove unnecessary config Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
While testing managed namespaces locally I noticed 2 issues:
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: