fix: retry token creation/deletion upon project conflict errors #11199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <jesse@akuity.io>
Codecov ReportBase: 45.60% // Head: 45.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11199 +/- ##
==========================================
+ Coverage 45.60% 45.63% +0.02%
==========================================
Files 239 239
Lines 28973 28987 +14
==========================================
+ Hits 13214 13228 +14
Misses 13940 13940
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM, Thanks @jessesuen |
jessesuen
added a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Jesse Suen <jesse@akuity.io>
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
…proj#11199) Signed-off-by: Jesse Suen <jesse@akuity.io>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…proj#11199) Signed-off-by: Jesse Suen <jesse@akuity.io> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user which is making heavy use of the token endpoint, will intermittently get kubernetes conflict errors. This change wraps the token create/delete endpoint with
retry.RetryOnConflictto avoid the issue.Signed-off-by: Jesse Suen jesse@akuity.io
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: