feat: display auto sync status in application details view #11200
Conversation
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Codecov ReportBase: 45.69% // Head: 45.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11200 +/- ##
=======================================
Coverage 45.69% 45.69%
=======================================
Files 239 239
Lines 29013 29013
=======================================
Hits 13257 13257
Misses 13934 13934
Partials 1822 1822 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| <div className='application-status-panel__item-name'> | ||
| {application.status && application.status.sync && application.status.sync.revision && ( | ||
| {application.status && application.status.sync && application.status.sync.revision && !application.spec.source.chart && ( | ||
| <div className='application-status-panel__item-name'> |
There was a problem hiding this comment.
this empty div makes no sense for Helm source (only for git)
|
@rbreeze I see your point, but I can't think of a different place. What if I change the area title, see mockup below? (Auto Sync Status vs Manual Sync Status) |
|
@rbreeze after SIG UI yesterday, I assume we can give this approach another chance? I will follow up with the application list filter in a separate PR. |
…11200) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software>
…11200) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com>
first minor change to display the auto sync status (enabled or not) in the application details page:
see enhancement proposal: #11102
Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: