New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use non distroless image for dex #11219
Conversation
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Codecov ReportBase: 45.60% // Head: 45.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11219 +/- ##
=======================================
Coverage 45.60% 45.60%
=======================================
Files 239 239
Lines 28973 28973
=======================================
Hits 13214 13214
Misses 13940 13940
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks to you both!
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Cherry-picked onto release-2.3 for 2.3.12, release-2.4 for 2.4.18, and release-2.5 for 2.5.3. |
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
* fix: use non distroless image for dex Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * change image in ci workflow Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Justin Marquis 34fathombelow@protonmail.com
Closes #11182
Closes #11105
Closes #11071
This PR reverts using a distroless image for Dex. There are permission errors between ArgoCD-dex & Dex binaries.
Two workarounds were tested successfully
or
First class stability and compatability should be provided. Rather than using a workaround that may be incompatible with certain cluster types.
Big thanks to @pdrastil for testing and verifying the workarounds and fix.