chore(docs): fix build, prepare for google analytics v4 (#10850) #11248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
2 tasks
Codecov ReportBase: 45.64% // Head: 45.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11248 +/- ##
=======================================
Coverage 45.64% 45.64%
=======================================
Files 239 239
Lines 28991 28991
=======================================
Hits 13233 13233
Misses 13939 13939
Partials 1819 1819 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chalin
approved these changes
Nov 10, 2022
chalin
reviewed
Nov 10, 2022
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
crenshaw-dev
changed the title
crenshaw-dev
approved these changes
Nov 14, 2022
|
Thanks for this update @alexef and @crenshaw-dev! ✨ |
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 17, 2022
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build codegen check Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build codegen check Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix build codegen check Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com
fixes: #10850
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: